Ruby code review
-
Upload
jonatas-paganini -
Category
Software
-
view
493 -
download
0
Transcript of Ruby code review
![Page 1: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/1.jpg)
ruby code REVIEW
@jonatasdp
![Page 2: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/2.jpg)
current status
![Page 3: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/3.jpg)
blessed :ship:
![Page 4: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/4.jpg)
Developer || Reviewer
![Page 5: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/5.jpg)
Scenario: developer
![Page 6: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/6.jpg)
your work mattersby Kent Beck
![Page 7: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/7.jpg)
meet std-lib
![Page 8: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/8.jpg)
meet std-lib
![Page 9: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/9.jpg)
meet your js framework
![Page 10: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/10.jpg)
meet your web framework
![Page 11: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/11.jpg)
hmm.
![Page 12: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/12.jpg)
knowledge << feedback
![Page 13: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/13.jpg)
learn details
![Page 14: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/14.jpg)
learn even details
![Page 15: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/15.jpg)
feedback matters
![Page 16: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/16.jpg)
feedback matters
![Page 17: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/17.jpg)
feedback = work together
![Page 18: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/18.jpg)
feedback matters
![Page 19: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/19.jpg)
meet your code base
![Page 20: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/20.jpg)
meet your codebase
![Page 21: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/21.jpg)
benchmark EVERYTHING
![Page 22: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/22.jpg)
review before review
![Page 23: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/23.jpg)
review before review
![Page 24: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/24.jpg)
e esse binding.pry aqui?¬¬
![Page 25: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/25.jpg)
git commit --verbose
![Page 26: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/26.jpg)
gitk
![Page 27: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/27.jpg)
look all PR’s you can!!!
![Page 28: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/28.jpg)
learn from other people
![Page 29: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/29.jpg)
baby steps
![Page 30: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/30.jpg)
avoid same mistake twice
![Page 31: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/31.jpg)
beautiful syntax is basic
![Page 32: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/32.jpg)
will it work?
![Page 33: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/33.jpg)
happy paths are so HAPPY
![Page 34: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/34.jpg)
happy paths are so happy
![Page 35: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/35.jpg)
benchmark your doubts
![Page 36: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/36.jpg)
is the best fit for now?
![Page 37: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/37.jpg)
can I indent your code?
![Page 38: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/38.jpg)
name everything
![Page 39: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/39.jpg)
name your regexes
![Page 40: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/40.jpg)
hack your code
![Page 41: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/41.jpg)
rebase histories in commits
![Page 42: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/42.jpg)
git rebase --interactive
![Page 43: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/43.jpg)
help your reviewer mind
![Page 44: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/44.jpg)
As a developer:provide context enough
![Page 45: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/45.jpg)
Scenario: reviewer
![Page 46: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/46.jpg)
your work mattersby Kent Beck
![Page 47: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/47.jpg)
ask if you don’t know
![Page 48: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/48.jpg)
ask. don’t tell.
![Page 49: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/49.jpg)
test/comprove your theory
![Page 50: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/50.jpg)
benchmark things you discover
![Page 51: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/51.jpg)
write beautiful markdown
![Page 52: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/52.jpg)
explain your job on commits
![Page 53: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/53.jpg)
wikify the best knowledge
![Page 54: Ruby code review](https://reader031.fdocuments.us/reader031/viewer/2022030218/5885ff901a28ab0a3f8b5423/html5/thumbnails/54.jpg)
As a reviewer:“do not believe in perfect Pull Requests”
by @joaohornburg