How reviewing code makes me a better programmer!
-
Upload
amy-hanlon -
Category
Technology
-
view
1.088 -
download
0
Transcript of How reviewing code makes me a better programmer!
![Page 1: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/1.jpg)
How$reviewing$codemakes&me&a&be(er&programmer!
Amy$Hanlon@amygdalama
![Page 2: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/2.jpg)
![Page 3: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/3.jpg)
![Page 4: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/4.jpg)
![Page 5: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/5.jpg)
receive&be(er&reviewsbecome&a&be(er&reviewerget$more$value$out$of$code$review
![Page 6: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/6.jpg)
Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4.✨+ask+clarifying+ques=ons+✨
5.✨+offer+sugges=ons+✨
![Page 7: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/7.jpg)
Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4.✨+ask+clarifying+ques=ons+✨
5.✨+offer+sugges=ons+✨
![Page 8: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/8.jpg)
give%context
![Page 9: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/9.jpg)
![Page 10: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/10.jpg)
make%small%changes
![Page 11: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/11.jpg)
Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4.✨+ask+clarifying+ques=ons+✨
5.✨+offer+sugges=ons+✨
![Page 12: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/12.jpg)
use$lin(ng$tools
![Page 13: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/13.jpg)
Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4.✨+ask+clarifying+ques=ons+✨
5.✨+offer+sugges=ons+✨
![Page 14: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/14.jpg)
write&tests
![Page 15: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/15.jpg)
QA#your#changes
![Page 16: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/16.jpg)
Recap:'authors1.#give#context
2.#make#small#changes3.#use#lin*ng#tools
4.#write#tests5.#QA#your#changes
![Page 17: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/17.jpg)
![Page 18: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/18.jpg)
Authors
![Page 19: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/19.jpg)
![Page 20: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/20.jpg)
say$how$done$you$are
![Page 21: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/21.jpg)
ask$for$specific$feedback
![Page 22: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/22.jpg)
get$feedback$early$and$o0en
![Page 23: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/23.jpg)
but$don't$work$too$far$upstream
![Page 24: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/24.jpg)
get$a$micro+yes
![Page 25: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/25.jpg)
welcome'ques+ons
![Page 26: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/26.jpg)
Recap:'authors1.#say#how#done#you#are
2.#ask#for#specific#feedback3.#get#feedback#early#and#o2en
4.#but#don't#work#too#far#upstream5.#get#a#micro-yes
6.#welcome#ques-ons
![Page 27: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/27.jpg)
Reviewers
![Page 28: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/28.jpg)
![Page 29: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/29.jpg)
review&at&the&right&level&of&detail
![Page 30: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/30.jpg)
if#the#code#is#confusing,it's%a%problem%with%the%code...or$an$opportunity$to$learn!
![Page 31: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/31.jpg)
beta%test'your'feedback
![Page 32: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/32.jpg)
communicate*the*why,
not$the$how
![Page 33: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/33.jpg)
Recap:'reviewers1.#review#at#the#right#level#of#detail2.#if#the#code#is#confusing,#it's#a#problem#with#the#code
...or$an$opportunity$to$learn!3.#beta(test#your#feedback4.#communicate#the#why,#not#the#how
![Page 34: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/34.jpg)
receive&be(er&reviewsbecome&a&be(er&reviewerget$more$value$out$of$code$review
![Page 35: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/35.jpg)
Thanks!Julia&Evans
Kamal%Marhubi
Sasha%Laundy
Tania%Luna
A.#Jesse#Jiryu#Davis
![Page 36: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/36.jpg)
Thank&you!Amy$Hanlon
@amygdalama
![Page 37: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/37.jpg)
Resources(&(Related(Reading• Death'to'the'Rubber'Stamp'(or:'ques4ons'I'ask'myself'when'reviewing)'h@p://mathamy.com/deathEtoEtheErubberEstamp.html
• The'Gentle'Art'of'Patch'Review'h@p://sarah.thesharps.us/2014/09/01/theEgentleEartEofEpatchEreview/
• Your'Brain's'API:'Giving'and'GeRng'Technical'Help'h@p://blog.sashalaundy.com/talks/askingEhelping/
• Rebecca's'Rules'for'Contruc4ve'Code'Reviews'h@ps://storify.com/ReBeccaOrg/rebeccaEsErulesEforEconstruc4veEcodeE
![Page 38: How reviewing code makes me a better programmer!](https://reader031.fdocuments.us/reader031/viewer/2022020301/58795a381a28ab1e388b4b63/html5/thumbnails/38.jpg)
Photos
h"p://media.wizards.com/images/magic/daily/li/li102_mindRot.jpgh"p://www.magic=ville.com/fr/carteart?ref=cmd056h/p://archive.wizards.com/mtg/images/daily/boab/boab85iugh576f8ghadsd.jpgh"p://getwallpapers.net/magic=the=gathering=artwork=mtg=jason=chan=wallpaper=33527/h"p://teresenielsen.typepad.com/.a/6a00e54fd89cec88340147e233f3ca970b=500wi