How Hard Can It Be? - A refactoring battle story

8/3/2019 How Hard Can It Be? - A refactoring battle story

1/89

HowHARDCan ItBE?

A refactoring battle story.@jonleighton


2/89

has_many :tasks,

:through => :projects

class Account


3/89

has_many :tasks,


has_many :comments,:through => :tasks

class Account


4/89

has_many :tasks,


has_many :comments,:through => :tasks

class Account


5/89


6/89


7/89

Task

comments


8/89

ProjectTask

comments tasks


9/89

AccountProjectTask

comments tasks projects


10/89

AccountProjectTask


tasks


11/89

AccountProjectTask


tasks


12/89

AccountProjectTask

comments tasks

comments

projects

tasks


13/89

AccountProjectTask

comments tasks

comments

projects

tasks


14/89

AccountProjectTask



15/89

AccountProjectTask

comments tasks

comments

projects


16/89

AccountProjectTask

comments tasks

comments

projects


17/89

AccountProjectTask

comments tasks

comments

projects

comments


18/89

AccountProjectTask

comments tasks

comments

projects

comments


19/89

comments tasks

comments

projects

comments

comments tasks

comments

projects

tasks


20/89


21/89

SELECT * FROM comments


22/89


INNER JOIN tasks ON ...


23/89


INNER JOIN projects ON ...



24/89


WHERE

projects.account_id = 1

INNER JOIN projects ON ...



25/89


26/89


27/89


28/89


29/89


30/89


31/89


32/89


33/89


34/89


35/89


36/89

classAssociationReflection


37/89

classAssociationReflection

def chain

if through?

source_reflection.chain +

through_reflection.chain

else

[self]

end

end


38/89

class ThroughReflection

Documents