Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

117
Patch Reviews Thanks ZenDoodles and xjm

description

pdf export for jam's drupal camp. also at https://github.com/zendoodles/slide-decks/blob/jam/patch-review/index.html

Transcript of Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Page 1: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Patch ReviewsThanks ZenDoodles and xjm

Page 2: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

YesCTCathy Theys

@YesCTCheppers, Gittip

I review patches, mostly for core these days.

And do other stuff like plan sprints and mentor.

Page 3: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

(https://www.youtube.com/watch?v=NvV38nJObIE&t=12m57s)

Page 4: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 5: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Getting patch reviewsAlso: how to find reviews

Page 6: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Be specific,what kind of review?

Page 7: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Use tagsneeds JavaScript reviewneeds architectural review,needs usability review,needs manual testing,needs screenshot

Page 8: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Up-to-date Issue Summaryhttps://drupal.org/contributor-tasks/write-issue-summary

Page 9: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 10: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 11: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 12: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 13: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Automatic instructionswork in progress at

https://drupal.org/node/2013222

Page 14: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Contributor taskdocuments

http://drupal.org/contributor-tasks/review

http://drupal.org/contributor-tasks/do-accessibility-review

Page 15: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Metas

Page 16: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 17: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 18: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

simplytest.me urlpattern is:

/project/drupal/8.x?patch[]=

http://simplytest.me/qa#developers

Page 19: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Give good reviews

Page 20: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Doing patch reviews

Page 21: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Finding issues toreview

Page 22: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

first simple! success!novice?initiativesmetas?focus?

Page 23: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 24: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 25: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 26: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 27: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 28: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Core initiativeshttps://drupal.org/community-initiatives/drupal-core

and https://drupal.org/node/2107085

Page 29: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 30: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 31: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 32: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 33: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 34: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 35: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 36: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 37: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 38: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Doing patch reviews

Page 39: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Full frontal nicety

Page 40: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Supportivespecificinclude linkssupport improvementask questionseducate

Page 41: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 42: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 43: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

http://dreditor.org

Page 44: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 45: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 46: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 47: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 48: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 49: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 50: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 51: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 52: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 53: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 54: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 55: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 56: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 57: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 58: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 59: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 60: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 61: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 62: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 63: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 64: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 65: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 66: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 67: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 68: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Does it work?fixes the issuestays in scopeno regressions

Page 69: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 70: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 71: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 72: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 73: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 74: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 75: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 76: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 77: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Edit

Page 78: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 79: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 80: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 81: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 82: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 83: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 84: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 85: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 86: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 87: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 88: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Does it make sense?readable?comments?is there a better way?

Page 89: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 90: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 91: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 92: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 93: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 94: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 95: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

StrategyScale

say whatsay how

Page 96: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

StrategyKinds of reviews

update the issue summaryupdate needs tags

Page 97: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Processcannot unreadperfect is enemy of good

Page 98: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 99: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 100: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 101: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

documentationissue summarytimein-code API docs (1354)hook_help()change records

http://drupal.org/list-changes/drupal

Page 102: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

PerformanceDon't guessprofile!

Page 103: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Accessibility

Page 104: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

bugWCAGATAGtext color contrastform fields are labeledkeyboard-usable (javascript)

Page 105: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

UsabilityUI changes need usabilityreviewbefore and after screenshots

Page 106: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Testingcheck coverageask for new testsverify tests-only fails

Page 107: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Coding Styleno tabs, trailing1354link! to docs

Page 108: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

drupal.org/documentation/git/interdiff

Page 109: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Read and checkconcerns?addressed?

Page 110: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

read, read, readfix simplefor scopefor understanding

Page 111: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

IDE

Page 112: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Resourcesdrupalize.me/guides/drupal-community-tools-and-core-mentoring

Page 113: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Page 114: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Resourcesdrupalladder.org/

Page 115: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Resourcesdrupal.org/contributor-tasks/reviewxjm.drupalgardens.com/review-guide

Page 116: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Actiondrupal mentoring office hours#drupal-contributedrupical.com

Page 117: Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

Thanks!https://drupal.org/node/2013222

https://drupal.org/core-mentoring