Code Review Kata with Gerrit
22
CODE REVIEW KATA WITH GERRIT / © Enalean, 2013 This work is licensed under a . Manuel Vacelet @vaceletm Creative Commons Attribution-ShareAlike 3.0 Unported License
-
Upload
enalean -
Category
Technology
-
view
520 -
download
1
description
Here are the slides of the code review kata given by Manuel at Open World Forum 2013. The exercice of code review is a key element to improve quality, to enable team members understanding and to share knowledge. Complementary to the pair-programming promoted by XP, code review is usually the unique case for distributed teams to make a real collaborative work on code. Gerrit is a tool for code review, based on Git. It comes from the Android project but, now, it is widely adopted by other free software communities (LibreOffice, Mediawiki, Eclipse, ...) as well as by large companies (Sony Mobile, Ericsson, SAP, Google, ...). In this session, we propose to understand how a good tool is essential for code review and how the couple GIT/Gerrit enables development teams to improve the quality of code.
Transcript of Code Review Kata with Gerrit
CODE REVIEW KATA WITHGERRIT
/
© Enalean, 2013
This work is licensed under a .
Manuel Vacelet @vaceletm
Creative Commons Attribution-ShareAlike 3.0 Unported License
BIO / CONTEXTEnalean CTO & developerTuleap
WHY TO REVIEW CODE?
WHERE IT COMES FROM?Well known practice in FLOSS worldVarious strategy: patches (LKML), "pull requests", ...
GERRIT
Comes from Android projectGit onlyusers: Eclipse, QT, Mediawiki, Sony, Motorola, Google,SAP, ...
http://code.google.com/p/gerrit/
GERRIT WORKFLOW
REVIEWS DASHBOARD
ONE REVIEW
PATCH
DIFF, COMMENTS
PUSH FOR REVIEWOne commit == One reviewShape your commits (history rewriting!)
git push ssh://[email protected]:29418 HEAD:refs/for/master
COMMITS: SIZE MATTERSBeware The Big OneDifficult to grasp itTiny not better whatsoever
SHAPE YOUR COMMITS!
GOOD PRACTICESReduce the wait listDefine review rulesDamn fast Continuous Integration
ACCESS CONTROL
CONCLUSIONPowerfulHigh learning curve@Enalean: highest dev ROI this year
QUESTIONS?
CREDITSIt's all about feedback - code review as a great tool in theagile toolboxScaling Up JGitDeploying Gerrit Code Review
