Code Review

ENTER

Code Peer Reviews

Leave your ego at the door

02.06.2014 Frank Sons – IPC Berlin 2014

Who am I?

Software Quality Engineer

Doing PHP/Java/etc. for ~15 years

PHP Usergroup Hamburg

Twitter: @FrankS

Still learning


So, what‘s this about?

Introducing Reviews

Collective Coder Ownership

The right tool for the right job

Beware the dragons!


A short introduction to reviews

Forget about the code for a moment…


Reviews aren‘t limited to code…


What‘s the idea?

6

Code Reviews are intended to find and fix mistakes overlooked in the initial

development phase, improving both the overall quality of software and the

developers' skills.

Wikipedia: Code review


Back to code reviews…

IBM: Inspection introduced 1970s

7

Strict checklist for approval


Absolutely not agile

„That‘s not my code!“

Collective code ownership is a mindset


What about the ego?

9

“Everyone has the right and freedom to totally suck in private.”

Jeff Atwood - @codinghorror


Forget about your ego!

10

“Attempt to be awesome in public and embrace the suck!”



Reviews are knowledge sharing!


Share within your team…

Product knowledge

Technical knowledge

Coding Standards

Transparency


Finding the right review method

What do you want to do today?


Just a second…

14

“Hey, you got a minute? I need some help with a small problem.”


Ad hoc

Takes only a few minutes

15

Happens anywhere


Little impact beyond problem

Talk to the duck


Take a look please…

17

“Can you take a look at my code please? Here is the branch.”


Peer deskcheck

Can be done asynchronous

18

Great for reviewing lots of code


Review tools work this way

We are agile!

19

“Let’s do this together!”


Pair programming

Driver and Navigator

20

Rapid Iterations


Review on the fly

Let me show you…

21

“Let me show you my code.”


Walkthrough

Author explains code

Developers ask Questions

Ideal to present and educate

Risk of overlooking critical code


We want maintainable code

23

Do you understand my code?


„Code Reading“

Reader doesn‘t know code

Other devs: „Eagle Eye view“

Author answers questions

Specific code section


Beware the dragons!

It can be tricky…


Egoless!

26

My ego ist not tied to my “perfect” or “imperfect” work product



Avoid the dragons

Leave the egos at the door

No fingerpointing

Follow up after review

Don‘t abuse result

Lack of knowledge


Keep this in mind

Three to seven participants

Keep it at two hours max

Think loud

Find problems not solutions

Review coverage vs. Project size


You will see the benefits

Code will be understandable

Knowledge is spread

Improves communication

Light house effects


JUST DO IT!


This helps…


Enjoy your reviews!

Reviews can help your team

32

Reviews are all about the mindset


Don‘t fear the dragons

Feedback welcome!

[email protected]

Twitter: @FrankS

slideshare.net/frank_sons

Ask for a card ;-)


Thanks!

Hope you enjoyed it!


Code Review

Technology

Transcript of Code Review